fix: incorrect return type for the .transaction method (#497)

electric-sql · Jan 15, 2025 · d6b981b · d6b981b
1 parent ddd4a68
commit d6b981b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.changeset/late-forks-joke.md b/.changeset/late-forks-joke.md
@@ -0,0 +1,5 @@
+---
+'@electric-sql/pglite': patch
+---
+
+Fix the return type of the `.transaction` method
diff --git a/packages/pglite/src/base.ts b/packages/pglite/src/base.ts
@@ -366,9 +366,7 @@ export abstract class BasePGlite
    * @param callback A callback function that takes a transaction object
    * @returns The result of the transaction
    */
-  async transaction<T>(
-    callback: (tx: Transaction) => Promise<T>,
-  ): Promise<T | undefined> {
+  async transaction<T>(callback: (tx: Transaction) => Promise<T>): Promise<T> {
     await this._checkReady()
     return await this._runExclusiveTransaction(async () => {
       await this.#runExec('BEGIN')

diff --git a/packages/pglite/src/interface.ts b/packages/pglite/src/interface.ts
@@ -112,9 +112,7 @@ export type PGliteInterface<T extends Extensions = Extensions> =
     ): Promise<Results<T>>
     exec(query: string, options?: QueryOptions): Promise<Array<Results>>
     describeQuery(query: string): Promise<DescribeQueryResult>
-    transaction<T>(
-      callback: (tx: Transaction) => Promise<T>,
-    ): Promise<T | undefined>
+    transaction<T>(callback: (tx: Transaction) => Promise<T>): Promise<T>
     execProtocolRaw(
       message: Uint8Array,
       options?: ExecProtocolOptions,