Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Vue hooks #177

Merged
merged 3 commits into from
Aug 14, 2024
Merged

feat: Implement Vue hooks #177

merged 3 commits into from
Aug 14, 2024

Conversation

msfstef
Copy link
Collaborator

@msfstef msfstef commented Aug 12, 2024

Adds Vue.js hooks for PGlite - will need to update documentation as well, and currently the location of /framework-hooks has anchors that don't quite work - will fix those up as well.

@msfstef msfstef requested a review from samwillis August 12, 2024 15:21
Copy link
Contributor

github-actions bot commented Aug 12, 2024

@github-actions github-actions bot temporarily deployed to pull request August 12, 2024 15:28 Inactive
Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great! only one typo

Changeset?

Do you recon we should add docs in code PRs or separately in PGlite?

packages/pglite-vue/src/dependency-injection.ts Outdated Show resolved Hide resolved
@msfstef
Copy link
Collaborator Author

msfstef commented Aug 13, 2024

@samwillis not sure if the first release needs a changeset (I don't want it to bump the version) - I should check the docs for that

re:docs - imo I think it would be good to have docs with the code PRs, but we might run into the versioning issue (i.e. docs making it to the website before the software is released), so perhaps let's start with separate as it's ok to delay the docs a bit as long as the package is up

@github-actions github-actions bot temporarily deployed to pull request August 13, 2024 12:50 Inactive
@msfstef msfstef merged commit aa81bf0 into main Aug 14, 2024
7 checks passed
@msfstef msfstef deleted the msfstef/vue-hooks branch August 14, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants