Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add typed provider generation utility to React integration #194

Merged
merged 12 commits into from
Aug 14, 2024

Conversation

msfstef
Copy link
Collaborator

@msfstef msfstef commented Aug 14, 2024

Add makePGliteProvider utility that accepts a type and spits out both a typed provider and a typed usePGlite hook.

I've updated the docs to put them under their own page and updated the links to it as well.

I've also split out the tests a bit and added a type test.

@msfstef msfstef requested a review from samwillis August 14, 2024 09:57
Copy link
Contributor

github-actions bot commented Aug 14, 2024

Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great, just one comment on the namespace types

docs/docs/framework-hooks/react.md Outdated Show resolved Hide resolved
@msfstef msfstef merged commit e0d205c into main Aug 14, 2024
6 of 7 checks passed
@msfstef msfstef deleted the msfstef/fix-react-types branch August 14, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants