Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres-pglite as submodule #461

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Postgres-pglite as submodule #461

wants to merge 22 commits into from

Conversation

copiltembel
Copy link
Contributor

This PR moves the postgres-pglite dependency out of this repo and adds it as a submodule. The postgres-pglite repo contains Postgres with pglite changes needed for this to work.

Tested with:

$ git clone --single-branch --branch=tudor/move-postgres-pglite-to-ext-repo --recurse-submodules https://github.com/electric-sql/pglite.git
$ cd pglite
$ pnpm install
$ pnpm build:all
$ cd packages/pglite/
& pnpm test

@copiltembel
Copy link
Contributor Author

copiltembel commented Dec 9, 2024 •
edited
Loading

Need to update the github actions.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

Built bundles:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

🚀 Deployed on https://6787dc1b2f6fc22a67eda700--pglite.netlify.app

samwillis
samwillis approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

We still have the ./extra and ./patches dirs, should we move them too? Or we do that in another step.

package.json
@@ -12,7 +12,7 @@
"ci:publish": "pnpm changeset publish",
"build:all": "pnpm wasm:build && pnpm ts:build",
"ts:build": "pnpm -r --filter \"./packages/**\" build",
"wasm:build": "bash ./cibuild/build-with-docker.sh"
"wasm:build": "bash -c \"pushd postgres-pglite && ./pglite/cibuild/build-with-docker.sh && popd && cp -r postgres-pglite/pglite/dist ./packages/pglite/release \""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now, but in a future tidy up we need to make this work cross platform (i.e. windows).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is very ugly but gets the job done!

@copiltembel
Copy link
Contributor Author

We still have the ./extra and ./patches dirs, should we move them too? Or we do that in another step.

Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwillis samwillis samwillis approved these changes

@pmp-p pmp-p Awaiting requested review from pmp-p

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@copiltembel @samwillis