-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Vue): nullish params in useLiveQueryImpl
#466
fix(Vue): nullish params in useLiveQueryImpl
#466
Conversation
useLiveQueryImpl
@samwillis this PR typically fixes #448 |
Indeed, thank you @yacineb 🙏 |
marked as draft because I think I could improve it further |
These latest changes both makes sure that the watcher receives an array of refs as well as returning getters values if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sandros94, this is great. I added a changeset, a test and fixed some formatting in your branch. Going to merge now 🥳
Fixes a small oversight on
useLiveQuery
anduseLiveIncrementalQuery
whenparams
are nullish.Eg. if we want to go brrr and subscribe to all updates to a particular table like: