Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adjust voice-recording seconds remaining notification to 30 seconds and limit to 5min #8776

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

[Feature] Adjust voice-recording seconds remaining notification to 30 seconds and limit to 5min #8776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f298d8
Adjust voice-recording seconds remaining notification to 30 seconds
OdinVex Mar 12, 2024
7bf5826
Adjust voice-clip time-limit to 5min
OdinVex Mar 12, 2024
9f5018d
Add changelog with details for Pull Request 8776
OdinVex Mar 12, 2024
922356c
Merge branch 'element-hq:develop' into develop
OdinVex Mar 23, 2024
b6624e8
Merge branch 'element-hq:develop' into develop
OdinVex Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.d/8776.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Adjusted default voice-clip length limit from 2min to 5min - User Accessibility
Adjusted default 10s notification for voice-clip time remaining to 30sec - User Accessibility
2 changes: 1 addition & 1 deletion vector-config/src/main/java/im/vector/app/config/Config.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ object Config {
/**
* The maximum length of voice messages in milliseconds.
*/
const val VOICE_MESSAGE_LIMIT_MS = 120_000L
const val VOICE_MESSAGE_LIMIT_MS = 900_000L

/**
* The strategy for sharing device keys.
Expand Down
2 changes: 1 addition & 1 deletion ...n/java/im/vector/app/features/home/room/detail/composer/voice/VoiceMessageRecorderView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ class VoiceMessageRecorderView @JvmOverloads constructor(
post {
callback.onRecordingLimitReached()
}
} else if (timeDiffToRecordingLimit in 10_000..10_999) {
} else if (timeDiffToRecordingLimit in 30_000..30_999) {
post {
val secondsRemaining = floor(timeDiffToRecordingLimit / 1000f).toInt()
voiceMessageViews.renderToast(context.getString(R.string.voice_message_n_seconds_warning_toast, secondsRemaining))
Expand Down