Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reference #8926

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix reference #8926

merged 1 commit into from
Nov 12, 2024

Conversation

erikhuizinga
Copy link
Contributor

@erikhuizinga erikhuizinga commented Oct 21, 2024 •
edited
Loading

The value should be the same, but the reference name was incorrect.

See the value definitions on develop (at this time):

element-android/dependencies.gradle

Lines 5 to 6 in 21e751e

'sourceCompat' : JavaVersion.VERSION_17,
'targetCompat' : JavaVersion.VERSION_17,

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

@erikhuizinga
Fix reference
bbcd48b 
The value should be the same, but the reference name was incorrect.
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bmarty
bmarty approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@bmarty bmarty merged commit 5537bf8 into element-hq:develop Nov 12, 2024
10 of 13 checks passed
@erikhuizinga erikhuizinga deleted the patch-1 branch November 12, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikhuizinga @CLAassistant @bmarty