Remove Generator in store_search_entries_txn (#17817)

Context: matrix-org/synapse#15439 (#15439) Also see discussion in #17813
element-hq · Oct 31, 2024 · 2e5fe3f · 2e5fe3f
1 parent af59a99
commit 2e5fe3f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/17817.bugfix b/changelog.d/17817.bugfix
@@ -0,0 +1 @@
+Avoid lost data on some database query retries.
diff --git a/synapse/storage/databases/main/search.py b/synapse/storage/databases/main/search.py
@@ -94,7 +94,7 @@ def store_search_entries_txn(
             VALUES (?,?,?,to_tsvector('english', ?),?,?)
             """
 
-            args1 = (
+            args1 = [
                 (
                     entry.event_id,
                     entry.room_id,
@@ -104,7 +104,7 @@ def store_search_entries_txn(
                     entry.origin_server_ts,
                 )
                 for entry in entries
-            )
+            ]
 
             txn.execute_batch(sql, args1)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Avoid lost data on some database query retries.