Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unstable MSC4151 implementation #18052

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Drop unstable MSC4151 implementation #18052

merged 4 commits into from
Jan 7, 2025

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Dec 26, 2024 •
edited
Loading

It's been rotated out of known clients, and should be safe for removal now.

Fixes #17373

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@turt2live
Drop unstable MSC4151 implementation
bab5c32 
It's been rotated out of known clients, and should be safe for removal now.

Fixes #17373
@turt2live
changelog
e587843
@turt2live
Clean up imports
647116d
@turt2live turt2live marked this pull request as ready for review December 26, 2024 23:55
@turt2live turt2live requested a review from a team as a code owner December 26, 2024 23:55
anoadragon453
anoadragon453 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping on top of this! 📝

Test failures are a flake and unrelated to this PR.

@turt2live
Copy link
Member Author

(assuming good to merge - please yell/revert if not)

@turt2live turt2live merged commit beea39f into develop Jan 7, 2025
39 checks passed
@turt2live turt2live deleted the travis/drop-msc4151-unstable branch January 7, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop unstable MSC4151 after November 19th, 2024
2 participants
@turt2live @anoadragon453