Add a column participant to room_memberships table
#18068
+217
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Shay
changed the title
participant to room_membership tableparticipant to room_memberships table
|
Requesting @anoadragon453's feedback on this as he has context. |
erikjohnston
reviewed
Jan 8, 2025
synapse/handlers/message.py
Outdated
| @@ -1440,6 +1440,9 @@ async def handle_new_client_event( | |||
| ) | |||
| return prev_event | |||
|
|
|||
| if event.type == "m.room.message": | |||
There was a problem hiding this comment.
Drive by comment: presumably we also want to include encrypted messages here? Which have their own event type?
There was a problem hiding this comment.
Good point! Thanks for picking up on that :)
H-Shay
commented
Jan 8, 2025
|
Delayed events complement test failure looks like a flake? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a column
participanttoroom_membershipstable to track whether a user has participated in a room - participation is defined as having sent am.room.messageorm.room.encryptedevent into the room.Related to #18040, the approach there to determine room participation was deemed too inefficient and adding this column was the recommend remedy.