Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move things from Application to MainWindow #283

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Conversation

danirabbit
Copy link
Member

Important to note that this branch doesn't introduce (or fix) #196

Moves a bunch of UI creation from the application class to the MainWindow class

Also moves window state saving to MainWindow. Doesn't attempt to modernize the schemas other than throttling and using a binding for the pane position

Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@danirabbit danirabbit merged commit 8b47cc2 into master Nov 2, 2018
@danirabbit danirabbit deleted the app-to-mainwindow branch November 2, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants