Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push-stack support #181

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

furiel
Copy link
Contributor

@furiel furiel commented Mar 24, 2018

This little patch adds a new interactive function to the api: helm-gtags-push-stack.

My motivation is I can typically jump around the code with the current api, but in some cases I use helm-grep-do-git-grep for jump, for example when I do not exactly know what is the tag I am looking for, or when I am looking for a complex expression. Even then my muscle memory triggers the helm-gtags-pop-stack, which jumps to a wrong location, as helm-grep-do-git-grep does not push location to the stack. With helm-gtags-push-stack, I could advice-add helm-grep-do-git-grep to push the location before search, letting me to continue to use helm-gtags-pop-stack safely.

In general, this function can be used to make other modules compatible with helm-gtags.

@furiel
Copy link
Contributor Author

furiel commented Apr 4, 2018

@syohex can you look into this? I would be happy to see helm-gtags-push-stack available in melpa.

@syohex syohex merged commit 71674c8 into emacsorphanage:master Mar 15, 2020
@syohex
Copy link
Contributor

syohex commented Mar 15, 2020

Thanks for PR

@furiel furiel deleted the helm-gtag-push-stack-support branch March 16, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants