-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Emacs on Appveyor #11
Conversation
Wonderful, now Travis is broken. @vermiculus Do we need to ensure that |
I'll see how I can help with Travis when I'm free again :-) |
Sure, take your time ;-) It fails on all OSX builds here: https://travis-ci.org/magit/libegit2/jobs/388730159#L5420, which corresponds to the line I linked above. |
Should we ask for help with this and #6 on the reddit thread too? |
I've been working on the macOS build over at flycheck/emacs-travis#19. It only seems to fail for Emacs 26+; not really sure what's going on yet. |
Update on the above: the macos build should work now. don't know why it was broken in the first place; I would just try restarting the build from travis. |
b4feb7e
to
b5e4e5e
Compare
Looks like the build is still failing. I'll look into it when I'm home in a few hours. |
It might be this project's own Makefile as opposed to emacs-travis.mk. |
No I'm pretty sure it's the symlink in emacs-travis.mk. Maybe it'd be simpler just to |
I don't think so, but I can confirm when I'm home. What makes me think so is that emacs-travis's own tests are passing for this configuration and the steps right before the failure and the reported target correspond to the emacs target in this Makefile: https://github.com/magit/libegit2/blob/b5e4e5e591f27dd6bea3a79d8b41bcbc2f5f06ad/Makefile#L35-L44 I might try basing this Makefile off the emake example repo -- that build seems to work (and there have been a few enhancements made since this was first implemented). |
I don't think I have push access to this branch (which makes sense as I don't have push access to the repo in general), so here's configuration that may work: https://gist.github.com/vermiculus/74f3396779f05b6c2e8a6daaaf88031b |
b5e4e5e
to
0a83ce3
Compare
@vermiculus I've added you as a collaborator to my fork, should give you push access to this branch. |
0a83ce3
to
8a2f918
Compare
Looks pretty good! |
8a2f918
to
b110f34
Compare
This adds an
emacs-appveyor.mk
that is the spiritual complement ofemacs-travis.mk
. It doesn't have all the bells and whistles of the latter though, I just tore out the things I didn't need and made sure it worked for our use cases.This PR also disables CI for 25.1 and 25.2. They take a while to run and presumably 25.3 should suffice for the 25.x line.
This should bring Windows CI up to par with Linux and OSX.