Add giga embeddings #1741
Open
Add giga embeddings #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KennethEnevoldsen
approved these changes
Jan 10, 2025
Comment on lines
+268
to
+269
| use_instructions=True, | ||
| ) |
There was a problem hiding this comment.
Can we add the training data annotation as well (we are going through models and adding that)
see_ #1561
There was a problem hiding this comment.
They haven't publish report yet, so I don't know anything about training dataset
Comment on lines
+127
to
+133
| # to passage prompts won't be applied to passages | ||
| if ( | ||
| not self.apply_instruction_to_passages | ||
| and prompt_type == PromptType.passage | ||
| and task.metadata.type == "s2p" | ||
| ): | ||
| instruction = None |
There was a problem hiding this comment.
Similar to jasper and nv-embed this model doesn't use prompt for passages. I think that can be helpful to add this to base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
InstructSentenceTransformerWrapperto useSentenceTransformemodels with instructions.Ref embeddings-benchmark/results#77
@ekolodin My results are a bit higher. Could you rerun your results using this implementation, or provide your implementation? My code for run
Checklist
make test.make lint.Adding a model checklist
mteb.get_model(model_name, revision)andmteb.get_model_meta(model_name, revision)