Fix: Ensures correct IME behavior when the text input area gains or loses focus. #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bircni
reviewed
Aug 2, 2024
| @@ -746,6 +746,10 @@ impl<'t> TextEdit<'t> { | |||
| } | |||
| } | |||
|
|
|||
| if state.ime_enabled && response.lost_focus() { | |||
There was a problem hiding this comment.
Couldnt you just leave the state.ime_enabled` ? Because if its true its getting set to false and else it is already false, so to me it seems like an unnecessary condition
There was a problem hiding this comment.
Couldn
t you just leave thestate.ime_enabled` ? Because if its true its getting set to false and else it is already false, so to me it seems like an unnecessary condition
When focus is moved elsewhere, you must set ime_enabled to 'false`, otherwise the IME will have problems when focus returns.
There was a problem hiding this comment.
sure the idea was the following
if response.lost_focus() {
state.ime_enabled = false;
}There was a problem hiding this comment.
sure the idea was the following
if response.lost_focus() { state.ime_enabled = false; }
Yes, I thought about this too. If ime_enabled is not true, there is no need to check lost_focus() , so there is a difference in speed and readability. Let's wait for emilk's opinion on which one is better.
thank you.
There was a problem hiding this comment.
Ok but if so it would be good to add a comment there anyway
rustbasic
changed the title
state.ime_enabled in multiple TextEdit.
emilk
pushed a commit
that referenced
this pull request
Aug 5, 2024
Fix: Changed the handling method of `Ime::Preedit(_, None)` Fix: backspace fail after ime input * Related #4358 * Related #4430 * Related #4436 * Related #4794 * Related #4896 * Closes #4908 Issues: backspace fail after ime input * #4908 (Chinese) Changed the handling method of `Ime::Preedit(_, None)`
rustbasic
changed the title
rustbasic
changed the title
emilk
approved these changes
Aug 28, 2024
rib
pushed a commit
to EmbarkStudios/egui
that referenced
this pull request
Sep 30, 2024
Fix: Changed the handling method of `Ime::Preedit(_, None)` Fix: backspace fail after ime input * Related emilk#4358 * Related emilk#4430 * Related emilk#4436 * Related emilk#4794 * Related emilk#4896 * Closes emilk#4908 Issues: backspace fail after ime input * emilk#4908 (Chinese) Changed the handling method of `Ime::Preedit(_, None)`
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
Fix: Changed the handling method of `Ime::Preedit(_, None)` Fix: backspace fail after ime input * Related emilk#4358 * Related emilk#4430 * Related emilk#4436 * Related emilk#4794 * Related emilk#4896 * Closes emilk#4908 Issues: backspace fail after ime input * emilk#4908 (Chinese) Changed the handling method of `Ime::Preedit(_, None)`
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
…oses focus. (emilk#4896) Fix: Ensures correct IME behavior when the text input area gains or loses focus. Fix: Handling `state.ime_enabled` in multiple `TextEdit`. Fix: A symptom of characters being copied when there are multiple TextEdits. * Related emilk#4137 * Related emilk#4358 * Closes emilk#4374 * Related emilk#4436 * Related emilk#4794 * Related emilk#4908 * Related emilk#5008 Fix Issues: When focus is moved elsewhere, you must set `state.ime_enabled = false`, otherwise the IME will have problems when focus returns. Fix Issues: A symptom of characters being copied when there are multiple TextEdits. Deletes all current `IME events`, preventing them from being copied to `other TextEdits`, without saving the `TextEdit ID`, ( Related Issues: Some `LINUX` seem to trigger an IME enable event on startup. So, when we gained focus, we do `state.ime_enabled = false`. )
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
Fix: Changed the handling method of `Ime::Preedit(_, None)` Fix: backspace fail after ime input * Related emilk#4358 * Related emilk#4430 * Related emilk#4436 * Related emilk#4794 * Related emilk#4896 * Closes emilk#4908 Issues: backspace fail after ime input * emilk#4908 (Chinese) Changed the handling method of `Ime::Preedit(_, None)`
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…oses focus. (emilk#4896) Fix: Ensures correct IME behavior when the text input area gains or loses focus. Fix: Handling `state.ime_enabled` in multiple `TextEdit`. Fix: A symptom of characters being copied when there are multiple TextEdits. * Related emilk#4137 * Related emilk#4358 * Closes emilk#4374 * Related emilk#4436 * Related emilk#4794 * Related emilk#4908 * Related emilk#5008 Fix Issues: When focus is moved elsewhere, you must set `state.ime_enabled = false`, otherwise the IME will have problems when focus returns. Fix Issues: A symptom of characters being copied when there are multiple TextEdits. Deletes all current `IME events`, preventing them from being copied to `other TextEdits`, without saving the `TextEdit ID`, ( Related Issues: Some `LINUX` seem to trigger an IME enable event on startup. So, when we gained focus, we do `state.ime_enabled = false`. )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Ensures correct IME behavior when the text input area gains or loses focus.
Fix: Handling
state.ime_enabledin multipleTextEdit.Fix: A symptom of characters being copied when there are multiple TextEdits.
Related Fix IME bug where currently typed characters got copied #4137
Related Improve IME support with new
Event::Ime#4358Closes Fix: A symptom of characters being copied when there are multiple TextEdits. #4374
Related IME for chinese #4436
Related Handle the IME event first in
TextEditto fix some bugs #4794Related backspace fail after ime input #4908
Related eframe Linux: Backspace & arrow keys are completely broken #5008
Fix Issues: When focus is moved elsewhere, you must set
state.ime_enabled = false, otherwise the IME will have problems when focus returns.Fix Issues: A symptom of characters being copied when there are multiple TextEdits.
Deletes all current
IME events, preventing them from being copied toother TextEdits, without saving theTextEdit ID,( Related Issues: Some
LINUXseem to trigger an IME enable event on startup. So, when we gained focus, we dostate.ime_enabled = false. )