Increase the threshold for snapshot tests #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lucasmerlin
commented
Oct 22, 2024
lucasmerlin
commented
- Related to Difference in rendering on windows, linux and macOS #5295
- I have followed the instructions in the PR template
lucasmerlin
added
exclude from changelog
tests
|
Preview available at https://egui-pr-preview.github.io/pr/5298-lucas/increase-snapshot-threshold |
emilk
approved these changes
Oct 23, 2024
| // We might have to increase the threshold if there are minor differences when running tests | ||
| // on different gpus or different backends. | ||
| let threshold = 0.0; | ||
| // The default is 0.1. |
There was a problem hiding this comment.
Default where? In dify? Does that matter?
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
* Related to emilk#5295 * [x] I have followed the instructions in the PR template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.