Make image extension lowercase before checking if it is supported #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RyanBluth
commented
Dec 18, 2024
RyanBluth
commented
- Images with capitalized extensions do not load because the list of extensions they are checked against is lowercase. The image extension is now converted to lowercase before comparing
- [x ] I have followed the instructions in the PR template
|
Preview available at https://egui-pr-preview.github.io/pr/5501-support-uppercase-image-ext |
RyanBluth
force-pushed
the
support-uppercase-image-ext
branch
from
c1ffa34 to
af9ff5a
Compare
emilk
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.