Do the invalidate in clusterDoBeforeSleep

Signed-off-by: Binbin <[email protected]>
enjoy-binbin · May 29, 2024 · 1513a9b · 1513a9b
1 parent db9f16f
commit 1513a9b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/cluster_legacy.c b/src/cluster_legacy.c
@@ -752,7 +752,6 @@ void clusterSaveConfigOrDie(int do_fsync) {
         serverLog(LL_WARNING, "Fatal: can't update cluster config file.");
         exit(1);
     }
-    clearCachedClusterSlotsResponse();
 }
 
 /* Lock the cluster config using flock(), and retain the file descriptor used to
@@ -4847,6 +4846,9 @@ void clusterBeforeSleep(void) {
 }
 
 void clusterDoBeforeSleep(int flags) {
+    /* Clear the cache if there are config changes here. */
+    if (flags & CLUSTER_TODO_SAVE_CONFIG) clearCachedClusterSlotsResponse();
+
     server.cluster->todo_before_sleep |= flags;
 }
 

diff --git a/src/config.c b/src/config.c
@@ -2612,7 +2612,6 @@ static int updateClusterIp(const char **err) {
 int updateClusterHostname(const char **err) {
     UNUSED(err);
     clusterUpdateMyselfHostname();
-    clearCachedClusterSlotsResponse();
     return 1;
 }