Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update package json for npm publish #205

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

huaweigu
Copy link
Contributor

@huaweigu huaweigu commented Nov 6, 2024

Motivation

It'd be helpful for devs to import this project (especially libraries) as a npm package.

Solution

  • Update package.json to be npm publish ready
  • TODO - automate this in action similar to this
    publish-npm:
     needs: build
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           registry-url: https://registry.npmjs.org/
       - run: npm ci
       - run: npm publish --access public
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
           token: ${{ secrets.NPM_TOKEN }}
    we just need to figure out where to host the secrets.

@@ -1,14 +1,31 @@
{
"name": "@erc6900/reference-implementation",
"version": "0.8.0-rc.5",
"name": "erc6900-reference-implementation",
Copy link
Contributor Author

@huaweigu huaweigu Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tired the original name first, but got

npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/@erc6900%2freference-implementation - Not found
npm ERR! 404 
npm ERR! 404  '@erc6900/[email protected]' is not in this registry.
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

This solution or this doc requires the user to sign up with erc6900 scope, but it is already in use..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I submitted a name dispute request. Would love to keep the org scope if possible...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it'd be great if we can get erc6900 back. I tried user name and org name, both unavailable..

@huaweigu huaweigu requested a review from a team November 6, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants