Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up comments #211

Merged
merged 1 commit into from
Dec 5, 2024
Merged

chore: clean up comments #211

merged 1 commit into from
Dec 5, 2024

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Dec 5, 2024 •
edited
Loading

Brings in change from erc6900/ERCs#10 as well as some nits.

@octane-security-app Octane Security App
Copy link

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • IExecutionHookModule.sol: Modified the preExecutionHook to specify that validation-associated hooks should receive the full calldata.
  • IExecutionModule.sol: Updated comment for clarity on the execution selector field in the ManifestExecutionFunction structure.
  • IModularAccount.sol: Whitespace adjustments were made for consistency, with no changes to the core functionality or features.
  • IValidationModule.sol: Capitalization of parameter descriptions has been standardized in the smart contract comments.

🔗 Commit Hash: 84bbb64

@jaypaik Graphite App
Copy link
Collaborator Author

jaypaik commented Dec 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jaypaik jaypaik marked this pull request as ready for review December 5, 2024 21:47
@jaypaik jaypaik requested a review from a team December 5, 2024 21:47
@octane-security-app Octane Security App
Copy link

Overview

Octane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉

🔗 Commit Hash: 84bbb64

@jaypaik jaypaik merged commit c9b256c into develop Dec 5, 2024
5 checks passed
@jaypaik jaypaik deleted the 12-05-chore_clean_up_comments branch December 5, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huaweigu huaweigu huaweigu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaypaik @huaweigu