-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shutter: collect data from smart contracts #13553
Draft
taratorio
wants to merge
21
commits into
main
Choose a base branch
from
shutter-sequencer-txns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+4,434
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratorio
added a commit
that referenced
this pull request
Jan 27, 2025
relates to #13383 takes a chunk of changes out of bigger shutter PR #13553 in which we collect data from various shutter smart contracts context on this PR: - smart contracts objects generated by `abigen` rely on `bind.ContractBackend` in order to be used - we currently do not have an implementation of that interface in Erigon (apart from `SimulatedBackend` which is used in testing - inherited from Geth) - in this PR im adding an implementation of `ContractBackend` which uses the `EthApi` jsonrpc object and directly calls it instead of going via http rpc and/or websocket (for log update subscriptions) - this is analogous to how we have `direct` and `remote` grpc clients for our grpc-based components - ive also wired the new contract backend to the shutter pool - this will be used in a subsequent PR (check the aforementioned PR #13553 for usages) note that this is needed also for @shohamc1 's work for native AA which is why it will be good to merge it in main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.