Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to match new config #707

Merged
merged 12 commits into from
Jan 15, 2025
Merged

Update docs to match new config #707

merged 12 commits into from
Jan 15, 2025

Conversation

bstrdsmkr
Copy link

@bstrdsmkr bstrdsmkr commented Jan 9, 2025 •
edited by downiec
Loading

Description

  1. Update documentation to reflect new config process
  2. New pre-commit hooks to auto-generate markdown documentation from available settings
  3. Update Globus implementation to use ESG-Search instead of talking directly to Solr (1.5 blocker)
  4. Speed up test runs by adding data-testid's vs other slower query methods
  5. Speed up front page load using <link rel="preload"> to load the frontend config and initial CMIP6 query as soon as possible
  6. Speed up build time, reduce package size by switching from babel to SWC
  7. Fix test memory leak by mocking out keycloak

Fixes # (issue)
#698

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bstrdsmkr bstrdsmkr force-pushed the settings-docs branch 7 times, most recently from eb8186d to 2cb2d76 Compare January 10, 2025 13:25
@bstrdsmkr bstrdsmkr changed the base branch from staticbuild-v1.3-fixes to staticbuild-v1.2.1 January 10, 2025 13:28
@bstrdsmkr bstrdsmkr changed the base branch from staticbuild-v1.2.1 to staticbuild-v1.3-fixes January 10, 2025 13:36
downiec and others added 7 commits January 10, 2025 08:48
@downiec
Updated the local config file used for local testing. The new file .l…
b6e0fa7 
…ocal_config, contains the configuration used when running Metagrid locally. Updated the manage_metagrid script to run Metagrid from the single docker-compose file. Updated some settings to use llnl instead of ornl for local development and testing. Removed some unused environment variable files after after testing that they aren't used. Left the default variables in place because Metagrid fails to build when several of the defaults aren't set, still working to troubeshoot why. Globus transfer steps in the front-end are working, however transfers seem to fail and need to be resolved.
@bstrdsmkr @downiec
Switch from CRA to Vite and clean up tests (esgf2-us#692)
9ebb0de 
* Switch from CRA to Vite and clean up tests

* Fixed issue with loading screen continuing even after cancel button click. Updated local test config. Globus transfers still not working.

---------

Co-authored-by: Zach Price <[email protected]>
Co-authored-by: downiec <[email protected]>
Fix proxy and redirects for globus auth on docker compose
166647c
Various lint and test fixes
0d20268
Update yarn.lock
0abd07d
@downiec
Some changes made to try and get globus transfers working.
9c71abf
Update docs to match new config
10ec11a 
Auto generate configuration documentation with pre-commit hooks
@bstrdsmkr bstrdsmkr force-pushed the settings-docs branch 7 times, most recently from 1b36775 to 3dbfb50 Compare January 10, 2025 15:49
downiec and others added 3 commits January 14, 2025 21:02
@downiec @bstrdsmkr
Includes some updates and minor fixes so that everything builds and r…
40c4ff1 
…uns correctly. Removed the GLOBUS_REDIRECT setting and did some cleanup of the manage_metagrid.sh functions.
@downiec @bstrdsmkr
Updated the test files to no longer use the act() functions, as they …
d31eeb0 
…are deprecated. Cleaned up and fixed some failing tests.
Fix esgsearch json tests
9570b72
@bstrdsmkr bstrdsmkr marked this pull request as ready for review January 15, 2025 12:01
@downiec downiec merged commit afa8eeb into esgf2-us:staticbuild-v1.3-fixes Jan 15, 2025
4 checks passed
downiec added a commit that referenced this pull request Jan 16, 2025
@downiec @bstrdsmkr
Staticbuild v1.3 fixes (#697)
aa5a775 
* Fix proxy and redirects for globus auth on docker compose

* Various lint and test fixes

* Update yarn.lock

* Some changes made to try and get globus transfers working.

* Update docs to match new config (#707)

* Updated the local config file used for local testing. The new file .local_config, contains the configuration used when running Metagrid locally. Updated the manage_metagrid script to run Metagrid from the single docker-compose file. Updated some settings to use llnl instead of ornl for local development and testing. Removed some unused environment variable files after after testing that they aren't used. Left the default variables in place because Metagrid fails to build when several of the defaults aren't set, still working to troubeshoot why. Globus transfer steps in the front-end are working, however transfers seem to fail and need to be resolved.

* Switch from CRA to Vite and clean up tests (#692)

* Switch from CRA to Vite and clean up tests

* Fixed issue with loading screen continuing even after cancel button click. Updated local test config. Globus transfers still not working.

---------

Co-authored-by: Zach Price <[email protected]>
Co-authored-by: downiec <[email protected]>

* Fix proxy and redirects for globus auth on docker compose

* Various lint and test fixes

* Update yarn.lock

* Some changes made to try and get globus transfers working.

* Update docs to match new config
Auto generate configuration documentation with pre-commit hooks

* Revert yarn.lock, fix more tests

* Includes some updates and minor fixes so that everything builds and runs correctly. Removed the GLOBUS_REDIRECT setting and did some cleanup of the manage_metagrid.sh functions.

* Updated the test files to no longer use the act() functions, as they are deprecated. Cleaned up and fixed some failing tests.

* Fix esgsearch json tests

* Minor test fixes to see if tests will pass on github (they pass locally).

---------

Co-authored-by: downiec <[email protected]>
Co-authored-by: Zach Price <[email protected]>

---------

Co-authored-by: Zach Price <[email protected]>
Co-authored-by: bstrdsmkr <[email protected]>
downiec added a commit that referenced this pull request Jan 16, 2025
@downiec @sashakames @bstrdsmkr
Staticbuild v1.3.0 update (#690)
e6b309f 
* Harden images and reorg

* fix timezone with package (#680)

* Joyride tutorials update (#679)

* Merged in latest v1.2.1

* Updates to the joyride tutorials and some minor bugfixes.

* Revert Markdown update to fix current jest testing error

* Updated React Markdown library and fixed the jest test errors.

* Some modifications to remove the build and linting errors that came up after the merge with latest branch.

* Load frontend config before rendering App

Stop tests from leaking calls to globus.org

* Some fixes to get the react front-end to build and get the postgres to start up. There are still errors with django session store.

* Fixed some linting errors so frontend should build correctly.

* Updated the local config file used for local testing. The new file .local_config, contains the configuration used when running Metagrid locally. Updated the manage_metagrid script to run Metagrid from the single docker-compose file. Updated some settings to use llnl instead of ornl for local development and testing. Removed some unused environment variable files after after testing that they aren't used. Left the default variables in place because Metagrid fails to build when several of the defaults aren't set, still working to troubeshoot why. Globus transfer steps in the front-end are working, however transfers seem to fail and need to be resolved.

* Switch from CRA to Vite and clean up tests (#692)

* Switch from CRA to Vite and clean up tests

* Fixed issue with loading screen continuing even after cancel button click. Updated local test config. Globus transfers still not working.

---------

Co-authored-by: Zach Price <[email protected]>
Co-authored-by: downiec <[email protected]>

* Staticbuild v1.3 fixes (#697)

* Fix proxy and redirects for globus auth on docker compose

* Various lint and test fixes

* Update yarn.lock

* Some changes made to try and get globus transfers working.

* Update docs to match new config (#707)

* Updated the local config file used for local testing. The new file .local_config, contains the configuration used when running Metagrid locally. Updated the manage_metagrid script to run Metagrid from the single docker-compose file. Updated some settings to use llnl instead of ornl for local development and testing. Removed some unused environment variable files after after testing that they aren't used. Left the default variables in place because Metagrid fails to build when several of the defaults aren't set, still working to troubeshoot why. Globus transfer steps in the front-end are working, however transfers seem to fail and need to be resolved.

* Switch from CRA to Vite and clean up tests (#692)

* Switch from CRA to Vite and clean up tests

* Fixed issue with loading screen continuing even after cancel button click. Updated local test config. Globus transfers still not working.

---------

Co-authored-by: Zach Price <[email protected]>
Co-authored-by: downiec <[email protected]>

* Fix proxy and redirects for globus auth on docker compose

* Various lint and test fixes

* Update yarn.lock

* Some changes made to try and get globus transfers working.

* Update docs to match new config
Auto generate configuration documentation with pre-commit hooks

* Revert yarn.lock, fix more tests

* Includes some updates and minor fixes so that everything builds and runs correctly. Removed the GLOBUS_REDIRECT setting and did some cleanup of the manage_metagrid.sh functions.

* Updated the test files to no longer use the act() functions, as they are deprecated. Cleaned up and fixed some failing tests.

* Fix esgsearch json tests

* Minor test fixes to see if tests will pass on github (they pass locally).

---------

Co-authored-by: downiec <[email protected]>
Co-authored-by: Zach Price <[email protected]>

---------

Co-authored-by: Zach Price <[email protected]>
Co-authored-by: bstrdsmkr <[email protected]>

---------

Co-authored-by: Zach Price <[email protected]>
Co-authored-by: Sasha Ames <[email protected]>
Co-authored-by: bstrdsmkr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bstrdsmkr @downiec