Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating behavior or dashboard to not be so intrusive. #337

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

safaci2000
Copy link
Contributor

Previous behavior:

  1. Delete all monitored dashboards
  2. Upload all dashboards from backup.

New Behavior:

  1. Upload all dashboards from backup overwriting existing Dashboards.
  2. Delete any dashboards that exists in grafana but are missing from backup.

@safaci2000 safaci2000 force-pushed the feature/spike branch 3 times, most recently from 037ce4c to 12bc624 Compare January 16, 2025 14:53
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.55%. Comparing base (0bb1b07) to head (f189025).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/service/dashboards.go 50.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   47.57%   47.55%   -0.02%     
==========================================
  Files          85       85              
  Lines        6647     6657      +10     
==========================================
+ Hits         3162     3166       +4     
- Misses       3117     3122       +5     
- Partials      368      369       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fixes #296

Previous behavior:
  1. Delete all monitored dashboards
  2. Upload all dashboards from backup.

New Behavior:
  1. Upload all dashboards from backup overwriting existing Dashboards.
  2. Delete any dashboards that exists in grafana but are missing from backup.
@safaci2000 safaci2000 merged commit 52ed9c6 into main Jan 16, 2025
5 checks passed
@safaci2000 safaci2000 deleted the feature/spike branch January 16, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants