Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous cleanup and refactoring #41

Merged
merged 8 commits into from
Dec 22, 2023

Conversation

jessebraham
Copy link
Member

Sorry, this started off with a couple little changes and grew into a bit of a mess 😅 Reviewing commit-by-commit will probably be easier.

There's really nothing interesting in this PR, but the changes essentially boil down to:

  • Simplify/improve the build script, less duplication
  • Refactor and clean up the io module
  • Alias Target type with a properly capitalized name (I thought it was a module initially)
  • Move the Transport type definitions into the library
  • Change the bit_buf struct field from u64 to u32 (closes tinfl bit_buf should be a u32 #38)
  • Assorted cleanup/updates/improvements

Tested with espflash:

Chip UART USB Serial JTAG
ESP32 N/A
ESP32-C2 N/A
ESP32-C3
ESP32-C6
ESP32-H2
ESP32-S2 N/A
ESP32-S3

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested a few chips and all worked fine!

@jessebraham jessebraham merged commit 6b444cf into esp-rs:main Dec 22, 2023
22 checks passed
@jessebraham jessebraham deleted the fixes/refactor branch December 22, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tinfl bit_buf should be a u32
2 participants