fix(spi_attach): Unattach previously attached SPI flash (ESPTOOL-847) #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
--spi-connection
not working correctly in esp-stub-flasher (original esptool.py commit: espressif/esptool@afaa7d2)spi_flash_attach
automatically during boot-up, while ROM does this only whenSPI_ATTACH
command is sent by esptool. This means, that stub flasher essentially tries to attach a flash chip twice if--spi-connection
is used.test_short_flash_to_external_stub
in esptool test suite.