Use latest published release of esp-hal
#74
Draft
+482
−572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main.rs
Outdated
| let peripherals = Peripherals::take(); | ||
| let system = peripherals.SYSTEM.split(); | ||
| let clocks = ClockControl::max(system.clock_control).freeze(); | ||
| let peripherals = hal::init(hal::Config::default()); |
There was a problem hiding this comment.
Just a note: not sure if there was any reason to use clocks at max speed, but we aren't using them now
There was a problem hiding this comment.
Not sure if it matters either but will update it just to keep it consistent with what we had, thanks
There was a problem hiding this comment.
And the stub just times out if I try to use UART. Will test with some other chips in a bit and see if there's any difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project has fallen quite far behind, so I have updated all dependencies, namely
esp-hal.Unfortunately there seem to be some issues with UART, at least on the ESP32-C6 which is what I used for testing. USB is working however. Will need further investigation, but just opening a draft for now regardless.