Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPIO: wakeup_enable: Return error instead of panic #2916

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jan 9, 2025

Closes #2710 I guess

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev added this pull request to the merge queue Jan 9, 2025
Merged via the queue into esp-rs:main with commit 2b80e4d Jan 9, 2025
28 checks passed
@bugadani bugadani deleted the gpio-infallible branch January 9, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPIO: Prefer compile-time checks over runtime checks where possible, prefer a fallible API over panics.
3 participants