Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not DerefMut into PAC register blocks #2918

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jan 9, 2025

This PR is a part of #2661 although that issue needs more work. In the mean time, this PR removes the virtualness (which isn't generally true) from peripheral singleton documentation, removes remnants of an old macro syntax, and removes the DerefMut impl that isn't needed.

Follow-up will include:

  • Removing logic from peripheral singletons and traits implemented for peripheral singletons
  • A review of GPIO interconnect's types - which ones are technically peripheral singletons in this context?
  • Use &self in the remaining peripheral singleton methods (in the spirit of GPIO: Avoiding &mut self when &self is safe to use. #2711 but not quite)
  • Removing DerefMut from PeripheralRef
  • Most likely removing the blanket Sealed for &mut impl Sealed implementation

@bugadani bugadani added status:needs-attention This should be prioritized skip-changelog No changelog modification needed and removed status:needs-attention This should be prioritized labels Jan 9, 2025
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Jan 10, 2025
Merged via the queue into esp-rs:main with commit 8bd49d7 Jan 10, 2025
29 of 31 checks passed
@bugadani bugadani deleted the peri branch January 10, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants