Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-wifi: fix possible deadlock #3015

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jan 22, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Fixes #3008

In case the rx-queue is overrun it was possible the drop-implementation of EspWifiPacketBuffer was called with interrupts disabled (which can cause a dead-lock).

Testing

See linked issue

@bjoernQ bjoernQ marked this pull request as ready for review January 22, 2025 12:53
esp-wifi/src/wifi/mod.rs Outdated Show resolved Hide resolved
@MabezDev MabezDev added this pull request to the merge queue Jan 22, 2025
Merged via the queue into esp-rs:main with commit 16af010 Jan 22, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential deadlock on esp32-c3 when using listening sockets on embassy-net
3 participants