Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the soundness fixes from embassy-hal-internal to our copy-pasted implementation, and modifies code where necessary to allow that change.
There are three noteworthy items:
&self
. These are supposed to be singletons, and they shouldn't really have user-facing APIs anyway.&mut self
wasn't really preventing anything anyway (e.g. we can race on GPIO configuration), but it was in the way of this PR.Closes #2661 as we now have an identical implementation to embassy, except for a few custom additions where we abuse the pattern a bit.