Remove OutputOpenDrain
#3029
Draft
Remove OutputOpenDrain
#3029
+380
−611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
commented
Jan 24, 2025
| <Channel<Async, 0> as RxChannelInternal>::unlisten_interrupt( | ||
| Event::End | Event::Error, | ||
| ); | ||
| <Channel<Async, 0> as TxChannelInternal>::unlisten_interrupt(Event::End | Event::Error); |
There was a problem hiding this comment.
mhhh - the xtask doesn't touch these lines for me but VSCode "Reformat Code" does 🤔 - would be good if they would agree (at least the CI checks don't care - not sure if that is a good or a bad thing)
There was a problem hiding this comment.
Well the result is better, but the reformatting is soooo unnecessary...
There was a problem hiding this comment.
oh - it seems that cargo fmt (and so does xtask fmt-packages) ignores modules which are contained in an unstable_module! { ... } 😲 - currently I can do "anything" in terms of formatting to e.g. rmt.rs and it will stay that way.
When I move the module out of the macro-invocation it gets reformatted (and the same way we see here)
bugadani
force-pushed
the
opendrain
branch
11 times, most recently
from
44f09fc to
8fda0d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3016
This PR walks back on the fallibility of the GPIO constructors, and moves the initial level out of the config struct.