Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.3.0 #719

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Version 3.3.0 #719

merged 2 commits into from
Jan 13, 2025

Conversation

jessebraham
Copy link
Member

Opening as a draft for now, not going to merge/release until Monday.

Just bumped the dependencies, the point of this release is mostly just to get the current changes in main published while we begin work on the next major release. This unfortunately resulted in a pretty hefty bump in the MSRV, but I don't really feel like fighting with different versions to find some middle ground, so it is what it is.

A couple dependencies are still outdated, as we have had issues when trying to update them (addr2line and crossterm). This is something I'd like to address in v4, but again not going to bother with it right now.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this

@kevin-june
Copy link

On the subject of MSRV, though a bit of a tangent / some foreshadowing:

Yesterday I encountered this error when installing espflash onto a system that was running Rust 1.82:

Caused by:
  failed to parse manifest at `/Users/jenkins/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bytemuck_derive-1.9.0/Cargo.toml`

Caused by:
  feature `edition2024` is required

  The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.82.0 (8f40fc59f 2024-08-21)).

After some digging around, it seems that bytemuck_derive had bumped its MSRV to 1.84 (with resolver set to 3) and released this in version 1.9.0. espflash pulls in this requirement through its dependency on bytemuck and its derive feature.

This version was yanked shortly after it was released, so the problem has gone away for now. For context, see the bytemuck_derive's version history and bytemuck/issues/294.

I still find it a bit confusing that the compiler suggested setting edition2024 rather than noting that the MSRV of Rust 1.84 was not met, so I might be missing something....

In any case, this this failure will likely reappear when bytemuck_derive deploys 1.9.0 again. If/when this happens, I hope that this information will help!

@jessebraham
Copy link
Member Author

Thanks for the heads up. I have added a note to the installation instructions to suggest using --locked when installing, which I guess is about as much as we can do about that right now 😅

@jessebraham jessebraham marked this pull request as ready for review January 13, 2025 08:31
@jessebraham jessebraham added this pull request to the merge queue Jan 13, 2025
Merged via the queue into esp-rs:main with commit 3c5de2b Jan 13, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants