-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release_notes.tpl.txt by adding a space between Docker image name and version #19153
Conversation
Add space between ${ETCD_VER} and Path Co-authored-by: sunfeilong <[email protected]> Signed-off-by: Ivan Valdes <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19153 +/- ##
==========================================
+ Coverage 68.77% 68.80% +0.02%
==========================================
Files 420 420
Lines 35649 35649
==========================================
+ Hits 24518 24528 +10
+ Misses 9704 9692 -12
- Partials 1427 1429 +2 Continue to review full report in Codecov by Sentry.
|
/cherrypick release-3.5 |
@ivanvc: new pull request created: #19157 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick release-3.4 |
@ivanvc: new pull request created: #19159 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add space between ${ETCD_VER} and Path Chery-pick commit 519a2e3 / pull request etcd-io#19153. Co-authored-by: sunfeilong <[email protected]> Signed-off-by: Ivan Valdes <[email protected]>
Add space between ${ETCD_VER} and Path Chery-pick commit 519a2e3 / pull request etcd-io#19153. Co-authored-by: sunfeilong <[email protected]> Signed-off-by: Ivan Valdes <[email protected]>
This PR supersedes #19122.
Add space between
${ETCD_VER}
and the path for docker commands.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.