Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release_notes.tpl.txt by adding a space between Docker image name and version #19153

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jan 9, 2025

This PR supersedes #19122.

Add space between ${ETCD_VER} and the path for docker commands.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Add space between ${ETCD_VER} and Path

Co-authored-by: sunfeilong <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 0edc5c0 into etcd-io:main Jan 9, 2025
34 checks passed
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (0f172d4) to head (519a2e3).
Report is 2 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19153      +/-   ##
==========================================
+ Coverage   68.77%   68.80%   +0.02%     
==========================================
  Files         420      420              
  Lines       35649    35649              
==========================================
+ Hits        24518    24528      +10     
+ Misses       9704     9692      -12     
- Partials     1427     1429       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f172d4...519a2e3. Read the comment docs.

@ivanvc
Copy link
Member Author

ivanvc commented Jan 9, 2025

/cherrypick release-3.5

@ivanvc ivanvc deleted the fix-release-notes-missing-space branch January 9, 2025 23:03
@k8s-infra-cherrypick-robot

@ivanvc: new pull request created: #19157

In response to this:

/cherrypick release-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member Author

ivanvc commented Jan 9, 2025

/cherrypick release-3.4

@k8s-infra-cherrypick-robot

@ivanvc: new pull request created: #19159

In response to this:

/cherrypick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ivanvc added a commit to ivanvc/etcd that referenced this pull request Jan 10, 2025
Add space between ${ETCD_VER} and Path

Chery-pick commit 519a2e3 / pull
request etcd-io#19153.

Co-authored-by: sunfeilong <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
ivanvc added a commit to ivanvc/etcd that referenced this pull request Jan 10, 2025
Add space between ${ETCD_VER} and Path

Chery-pick commit 519a2e3 / pull
request etcd-io#19153.

Co-authored-by: sunfeilong <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants