[Interop] Add circom circuits #725
Conversation
biscuitdey
requested review from
skarred14,
ognjenkurtic,
Therecanbeonlyone1969,
Manik-Jain,
skosito,
Kasshern and
Ybittan
as code owners
| template Circuit(nodes){ | ||
|
|
||
| //Non-inclusion Merkle Proof inputs | ||
| signal input merkelizedInvoiceRoot; |
There was a problem hiding this comment.
should that not be merkelizedBankStateObject?
| signal input merkelizedInvoiceRoot; | ||
| signal input stateTreeRoot; | ||
| signal input stateTree[nodes]; | ||
| signal input stateTreeLeafPosition[nodes]; |
There was a problem hiding this comment.
Same comment as above. Reference to BankStateObject
|
|
||
| template Circuit(nodes){ | ||
|
|
||
| //Non-inclusion Merkle Proof inputs |
There was a problem hiding this comment.
And we need proof of inclusion, not non-inclusion.
| signal input stateTree[nodes]; | ||
| signal input stateTreeLeafPosition[nodes]; | ||
|
|
||
| //Signature inputs |
There was a problem hiding this comment.
We need the verification of signatures of ACME and ACME Customer
There was a problem hiding this comment.
@biscuitdey Looks good ... left a couple of comments. The primary comment is that we need to verify the signature of the ACME customer over the bank data object and the signature of ACME over the bank data object signed by the ACME customer.
|
Core-devsw 30.10.2023. |
|
Core dev 11/13 - Pending @biscuitdey to review comments |
|
This PR uses Ecdsa circuits. As we are moving to Eddsa signatures in the circom circuits, I am closing this PR. |
Description
Add the circom circuits for the interop demo. The circuit includes the non-inclusion merkle proof verifier and ecdsa signature verifier.
Related Issue
#724
Motivation and Context
Interop demo circuits
How Has This Been Tested
Tests will be added in future PRs
Types of changes
Checklist