Upload Adhoc notebooks #1237
Draft
Upload Adhoc notebooks #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithium323
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Looks great! It's good to save this code so others can leverage it!
One comment on the use of the API token in the notebook. I would advocate for using os.environ as a way to get the api token. If we have a place in a cell where we can paste it then we are at risk of saving and pushing a commit with the credential.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upload Ad-hoc Notebooks for Github, TVL & User balance data