Gnosis Chain update #516
Open
Gnosis Chain update #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With associated svg asset, and update to README and hardhat.config. Recently rebranded from xDai.
pettinarip
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
LGTM @wackerow 🚀
Just commented there to update the rpc urls.
One more thing. We are trying to deprecate this repo (we probably should mention this somewhere or block the repo) in favor of the monorepo. So, if you have the time, please submit the PR into the monorepo, I think it would be useful.
| @@ -42,7 +42,7 @@ const config: HardhatUserConfig = { | |||
| url: process.env.JSONRPC_HTTP_URL || 'http://127.0.0.1:8545', | |||
| accounts, | |||
| }, | |||
| xdai: { | |||
| gnosis: { | |||
| url: process.env.JSONRPC_HTTP_URL || 'https://rpc.xdaichain.com', | |||
There was a problem hiding this comment.
Suggested change
| url: process.env.JSONRPC_HTTP_URL || 'https://rpc.xdaichain.com', | |
| url: process.env.JSONRPC_HTTP_URL || 'https://rpc.gnosischain.com', |
| explorerLabel: 'Blockscout', | ||
| rpcUrl: 'https://rpc.xdaichain.com/', | ||
| rpcUrl: 'https://rpc.xdaichain.com', |
There was a problem hiding this comment.
Suggested change
| rpcUrl: 'https://rpc.xdaichain.com', | |
| rpcUrl: 'https://rpc.gnosischain.com', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently xDai has been rebranded to Gnosis Chain. This implements this new naming scheme.
@pettinarip Would you mind double checking that these changes won't affect anything on the subgraph side?