Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: update blockProcFeed in insertChain #31065

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zsfelfoldi
Copy link
Contributor

This PR moves the updating of the blockProcFeed event feed from InsertChain to insertChain in order to ensure that the feed subscribers are notified whenever block processing happens.
Note that this event is not subscribed to anywhere in our codebase at the moment, earlier it was used by the LES server to avoid slowing down block processing. Now I want to do the same with the log indexer, the problem is that back then every block insertion was done by InsertChain, now the regular payload insertion is done by InsertBlockWithoutSetHead. Both of these (and also SetCanonical if needed) calls insertChain so I moved the feed update there.

@rjl493456442
Copy link
Member

rjl493456442 commented Jan 23, 2025

Unfortunately, the insertChain might be called by itself via insertSideChain, or via recoverAncestors.

The event stream could be something like this:

Process: True, Process: True, Process: false, Process: True, Process: false, Process: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants