Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct modalDialogCustomPromp typo in data-id attributes #5659

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: correct modalDialogCustomPromp typo in data-id attributes #5659

wants to merge 8 commits into from
+9 −9

Conversation

prestoalvarez
Copy link
Contributor

This PR fixes a typo in the data-id attribute values across multiple files:

Changed modalDialogCustomPromp to modalDialogCustomPrompt in:

  • apps/remix-ide-e2e/src/tests/terminal.test.ts
  • apps/remix-ide-e2e/src/tests/gist.test.ts
  • apps/remixdesktop/test/tests/app/gist.test.ts
  • libs/remix-ui/app/src/lib/remix-app/components/modals/modal-wrapper.tsx

The fix ensures consistency in naming conventions and corrects the misspelling of Prompt in the data-id attribute.

@netlify Netlify
Copy link

netlify bot commented Jan 19, 2025 •
edited
Loading

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b8681ee

@Aniket-Engg
Copy link
Collaborator

@prestoalvarez e2e are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestoalvarez @Aniket-Engg