Utp packet heap #702
Open
Utp packet heap #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolytec3
reviewed
Jan 10, 2025
| this.logger.extend('PROCESS_CURRENT_PACKET')(`Packet ${this.currentPacket.header.seqNr} already processed.`) | ||
| this.currentPacket = this.packetHeap.pop() | ||
| return this.processCurrentPacket() | ||
| } else if (this.currentPacket.header.seqNr > request.socket.reader!.nextDataNr) { |
There was a problem hiding this comment.
This is what makes selective acks basically never happen, right?
There was a problem hiding this comment.
Right -- this still lacks a way to respond to actual packet loss. This will just happen infinitely (or till other side sends a RESET).
There was a problem hiding this comment.
Commit 774053c adds some logic to process out of order packets if there are 3 or more packets for that request in the heap. This preserves the reordering for the packet pair phenomenon, but still allows the selective ack response to happen if we get more than 3 packets ahead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces uTP Packet Queue array with
Heapfromheap-js.Heap will sort packets waiting in queue so that out-of-order packets are reordered. This will cut back on unnecessary
Selective Ackresponses.When receiving streams, especially from
Trinnodes, we often receive pairs of packets with identical timestamps, and regularly end up processing them in the wrong order.Selective Ackfunction. We report every other packet at missing, even though it isn't. So We get multiples of every other packet and send extraACKpackets.The
processCurrentPacketmethod was updated to skip repeat packets, and to requeue packets that arrive ahead of the current reader position. This update allows the packet-pair phenomenon to self correct.Also updated and improved some logs, and added a method to report the total number of open uTP streams.