Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: little-endian conversion truncate #19

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

Officeyutong
Copy link
Contributor

Closes #17
Add truncation for little-endian conversion

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.73%. Comparing base (d95c50e) to head (953e01d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   81.00%   81.73%   +0.73%     
==========================================
  Files           5        5              
  Lines         979      980       +1     
  Branches      102      104       +2     
==========================================
+ Hits          793      801       +8     
+ Misses        186      179       -7     
Flag Coverage Δ
bpf_conformance 67.75% <100.00%> (+0.74%) ⬆️
unittests 55.81% <43.75%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Officeyutong
Copy link
Contributor Author

They are passed now:
image

@yunwei37 Do we need to get Codecov CI passed now?

@Officeyutong Officeyutong marked this pull request as ready for review August 31, 2024 08:45
@yunwei37
Copy link
Member

You can change the bpf conformance checking test in ci (There will be bpf conformance running 2 times, one for checking and one for publishing the result)

Enable the check For bpf cobformance can affect the coverage

@yunwei37 yunwei37 merged commit 658ba89 into eunomia-bpf:main Sep 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] le**-high instructions fail in bpf_conformance test
2 participants