synchronized vocabularies loading improved

europeana · Apr 23, 2024 · 9d4d0c7 · 9d4d0c7
1 parent 90008c6
commit 9d4d0c7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...go/src/main/java/eu/europeana/entitymanagement/mongo/repository/VocabularyRepository.java b/...go/src/main/java/eu/europeana/entitymanagement/mongo/repository/VocabularyRepository.java
@@ -22,16 +22,16 @@ public class VocabularyRepository  {
   private List<Vocabulary> europeanaRoles;
 
   public List<Vocabulary> getEuropeanaRoles() {
-    if(europeanaRoles==null) {
-      synchronized(this) {
+    synchronized(this) {
+      if(europeanaRoles==null) {
         europeanaRoles=new ArrayList<>();
         europeanaRoles.addAll(
             datastore.find(Vocabulary.class)
             .iterator()
             .toList());
       }
+      return europeanaRoles;
     }
-    return europeanaRoles;
   }
 
   /**