1) org country improved to contain only id, type, and prefLabel; 2) #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiple retrieval improved to handle old org ids
gsergiu
requested changes
Mar 5, 2024
| public class XmlEdmCountry { | ||
|
|
||
| @XmlAttribute(namespace = NAMESPACE_RDF, name = XmlConstants.RESOURCE) | ||
| private String about; |
There was a problem hiding this comment.
we should rename this field to match the xml field name
|
|
||
| for (EntityRecord entityRecord : entityRecords) { | ||
| sortedEntityRecordMap.replace(entityRecord.getEntityId(), entityRecord); | ||
| Optional<EntityRecord> recordIdMatched= entityRecords.stream().filter(er -> id.equals(er.getEntityId()) || er.getEntity().getSameReferenceLinks().contains(id)).findFirst(); |
There was a problem hiding this comment.
this sorting and generation of the final list needs to be moved to the Service, it is business logic that doesn't belong to the controller
There was a problem hiding this comment.
the filtering of null values on line 662 is now redundant, as the null values are not added to the map values anymore
gsergiu
reviewed
Mar 5, 2024
| @@ -586,7 +586,7 @@ protected void processCountryReference(Organization org) { | |||
| // replace wikidata country ids | |||
| org.setCountryId(europeanaCountryId); | |||
| // search reference | |||
| EntityRecord orgCountry = entityRecordRepository.findByEntityId(europeanaCountryId); | |||
| EntityRecord orgCountry = entityRecordRepository.findEntityRecord(europeanaCountryId); | |||
There was a problem hiding this comment.
this still retrieves the whole record from the database, while we only need the entityId and the pref labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple retrieval improved to handle old org ids