EA-3704 add info endpoint languages supported logic at stratup #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsergiu
reviewed
Feb 7, 2024
| @@ -83,7 +120,7 @@ public <T> T getTranslationApiResponse(WebClient webClient, Function<UriBuilder, | |||
| } | |||
|
|
|||
| LOGGER.debug("Translation API Client call failed - {}", e.getMessage()); | |||
There was a problem hiding this comment.
should add the LOGGER.isDebugEnabled() condition
| return builder.build(); | ||
| }; | ||
| } | ||
|
|
||
| private static JsonNode getConfigNode(String json) throws TranslationApiException { | ||
| if (!StringUtils.isEmpty(json)) { |
There was a problem hiding this comment.
there is a more efficient way to extract the required JsonNode only, which will simplify significantly this code:
https://cassiomolin.com/programming/using-jackson-and-json-pointer-to-query-and-parse-an-arbitrary-json-node/
would be nice to update the implementation to use this approach
ObjectMapper mapper = new ObjectMapper();
JsonNode node = mapper.readTree(json);
JsonNode coordinatesNode = node.at("/address/coordinates");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.