DateRange last day selection fix #2981
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwongz
changed the title
|
Need to test this with data that is hourly instead of daily to make sure we aren't overdisplaying |
|
Currently, the Max date is Wed Jun 19 2024 20:00:00 GMT-0400 (Eastern Daylight Time), which goes into Thursday June 20th UTC time. With the 'extraDay - date disabled' fix the daterange does not over display |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, added an extra day to
max rangeto account for whenstart dateandend dateare on the end date range, causing therangeCalendarto deselect the date. The extra day is disabled, to the user everything looks normal, behind the scenes we are handling what is most likely a timezone issueBefore:
Screen.Recording.2025-01-07.134437.mp4
After:
Screen.Recording.2025-01-07.134625.mp4
I attempted to test the time zones in London, SF and Toronto, the last date deselection issue persisted.
Attempted to add times to possible dates' start and end range, resulting in weird behavior. Would it best to add a new library to handle dates with times? currently, date formmater is only for dates without times.
Tried to look into changing selection dates, start selection at 00h:00m:00s and end selection 23h:59m:59s, but couldn't find a way in range calendar bits UI to handle that.
Checklist