Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darts] : Add Approaches #3386

Merged
merged 5 commits into from
Nov 30, 2024
Merged

[Darts] : Add Approaches #3386

merged 5 commits into from
Nov 30, 2024

Conversation

BethanyG
Copy link
Member

@BethanyG BethanyG commented Apr 5, 2023

No description provided.

@BethanyG BethanyG marked this pull request as draft April 5, 2023 22:00
@BethanyG BethanyG changed the title [Darts] Rough Draft of Approaches [Darts] : Add Approaches Nov 30, 2024
@BethanyG BethanyG marked this pull request as ready for review November 30, 2024 00:16
@colinleach
Copy link
Contributor

Looking good! I spotted a couple of small typos, but nothing major, and it reads well.

As a Brit (specifically, a northern Brit, from a region where this is a very common pub game), I find it startling to see a dart throw called a "toss". However, that's from problem-specifications and not worth messing with. Is this standard American English?

@BethanyG
Copy link
Member Author

BethanyG commented Nov 30, 2024

As a Brit (specifically, a northern Brit, from a region where this is a very common pub game), I find it startling to see a dart throw called a "toss". However, that's from problem-specifications and not worth messing with. Is this standard American English?

TIL that it was William 'Bigfoot' Anakin we have to thank for it being a pub game. He proved it wasn't a "game of chance", and therefore could be allowed in Pubs. who knew?. And a Lancashire carpenter (Brian Gamlin) who came up with the scoring system.

Toss is what I intuitively used, but I suspect the canonical data primed me to use that. Being that this game likely originated in The British Isles and France (where it was called butt at one point), perhaps we should use the term that they most commonly use. I'll comb through and replace things with throw. 😄

Edited to add: Given that this is a region-specific origin game (and the "toss" connotation), I think we should consider a PR to change the description in problem-specs. If you google "toss" vs "throw", it comes back as "throw". So if its "Darts" we are playing, then it is a throw. 😄 Here is a nudge to start the discussion in the forum. 💙

@colinleach
Copy link
Contributor

I'll comb through and replace things with throw. 😄

A pretty gutsy decision, to open this can of worms! I'll do nothing for today, hoping you'll just merge your PR and move on to something more urgent...

But it is, of course, your choice.

@BethanyG
Copy link
Member Author

A pretty gutsy decision, to open this can of worms! I'll do nothing for today, hoping you'll just merge your PR and move on to something more urgent...

I mean, we also have the issue that this really isn't Darts -- we use an Archery target for the exercise icon, and we are only doing the 1x, 2x, 3x portion of the target -- not the individual scoring sections. But I am not going to be that a-hole that renegotiates the exercise for the sake of .. reasons 😉 In fact, we can keep the description as-is until someone notices or brings up toss vs throw. Then we can wade in at that point. Or not.

But it did give me a flash of inspiration: If we make an exercise that does flesh out the Darts rules, we could possibly set that up as the complex numbers learning exercise. Bear with me here ..... since you could use the imaginary part for rotation, that could be the setup for scores, with the distance from center being the multipliers. I would have to really play with it to see if it could be set up without massive confusion, but.

I am indeed going to move on to more urgent concerns. This is about getting the queue down, and also getting your work reviewed and merged. Thank you for reviewing this. Never thought I would be doing so much writing for a coding site.

@BethanyG BethanyG merged commit db94cb0 into exercism:main Nov 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants