DeployBlueGreenAction class to handle CodeDeploy deployments #121
Conversation
…/ecs-deploy into feature/blue-green-deploy
|
|
||
| message = 'Successfully changed task definition to: %s:%s\n' % ( | ||
| task_definition.family, | ||
| task_definition.revision | ||
| ) | ||
|
|
||
| if type(deployment) == DeployBlueGreenAction: | ||
| _cd_deploy_url = 'https://us-east-1.console.aws.amazon.com/codesuite/codedeploy/deployments/' |
There was a problem hiding this comment.
@joaoricardo000 Will it always be us-east-1? Or should it be the same region as you are deploying to?
There was a problem hiding this comment.
I agree, this needs to be configurable, like the regions are in the deploy, scale, etc. commands.
In addition this should be configured and falling back to a default inside the Action, not in the CLI controller, please.
| 'Properties': { | ||
| 'TaskDefinition': task_definition.arn, | ||
| 'LoadBalancerInfo': { | ||
| 'ContainerName': self.service['loadBalancers'][0]['containerName'], |
There was a problem hiding this comment.
Does this imply, that a task definition does not have more than one containers?
| return self._deployment_target_id | ||
|
|
||
| def deploy(self, task_definition): | ||
| response = self.client.codedeploy.create_deployment( |
There was a problem hiding this comment.
Actually this like makes the class to a "codedeploy-deploy" tool, rather then an "ecs-deploy" too.
I'm still thinking, if this use-case might be a bit out of the scope of the project.
|
|
||
| message = 'Successfully changed task definition to: %s:%s\n' % ( | ||
| task_definition.family, | ||
| task_definition.revision | ||
| ) | ||
|
|
||
| if type(deployment) == DeployBlueGreenAction: | ||
| _cd_deploy_url = 'https://us-east-1.console.aws.amazon.com/codesuite/codedeploy/deployments/' |
There was a problem hiding this comment.
I agree, this needs to be configurable, like the regions are in the deploy, scale, etc. commands.
In addition this should be configured and falling back to a default inside the Action, not in the CLI controller, please.
|
Anything I can do to get this over the finish line? or, another option would be to have a flag to disable the deploy after updating the task def. |
ecs deployfunction.--cd-application-name AppECS-service-name--cd-application-nameis given, aDeployBlueGreenActioninstance is created to handle the creation and monitoring of the CodeDeploy deployment process.Example call/output:
Related to #120