Fix #280 Unidle Jenkins only if needed #282
Conversation
This patch refactors un-idling to proxy's startJenkins function which unildes jenkins only if it the state is "idled"
|
Can one of the admins verify this patch? |
Ike Plugins (test-keeper)Thank you @sthaha for this contribution! It appears that no tests have been added or updated in this PR. Automated tests give us confidence in shipping reliable software. Please add some as part of this change. If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command For more information please head over to official documentation. You can find there how to configure the plugin - for example exclude certain file types so if PR contains only them it won't be checked. |
| return | ||
| } | ||
|
|
||
| if state == clients.Idled { |
There was a problem hiding this comment.
I remember you saying that even if jenkins is idling then also we have three states
Running -> Intermediate -> Idled. Is that right?
If the state is Intermediate, it would be worth knowing if Jenkins is idling or un-idling. But let's do that as a different PR, WDYT?
There was a problem hiding this comment.
@kishansagathiya at present idler does not give us that information. We need to build that logic into idler which should return state like "starting", "running", "idling", "idled" which at the moment, it doesn't and thus can't be built into proxy.
There was a problem hiding this comment.
Makes sense. Let's create an issue for that?
There was a problem hiding this comment.
|
[test] |
1 similar comment
|
[test] |
|
/ok-without-tests |
This patch refactors un-idling to proxy's startJenkins function
which unildes jenkins only if it the state is "idled"