added support for Pysa Model Validation in VSCode Extension

[m0mosenpai]

Follow up to #409

This PR adds the implementation of model validation feature into Pysa's VSCode Plugin.

Working Examples

Screenshots showing the running extensions after these changes (the errors displayed are such due to misconfigured typeshed)

The edge case where Pyre is not able to parse the file, the following error is displayed and the extension continues to work:

[gbleaney]

Changes looking pretty good! Can you please rebase on master, now that we've landed your previous PR?

[facebook-github-bot]

@gbleaney has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.

[gbleaney]

Looks pretty great! Some really small comments. At the same time I'll import this and make sure it passes our internal CI

[facebook-github-bot]

@gbleaney has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.

[gbleaney]

@m0mosenpai there are two tests failing:
https://github.com/facebook/pyre-check/pull/433/checks?check_run_id=3111924028
https://github.com/facebook/pyre-check/pull/433/checks?check_run_id=3111924020

I believe you should be able to tweak both of the tests to do the import from one level higher (like you're doing locally). That should unblock landing this PR

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.

[m0mosenpai]

@m0mosenpai there are two tests failing:
https://github.com/facebook/pyre-check/pull/433/checks?check_run_id=3111924028
https://github.com/facebook/pyre-check/pull/433/checks?check_run_id=3111924020

I believe you should be able to tweak both of the tests to do the import from one level higher (like you're doing locally). That should unblock landing this PR

@gbleaney
I think i'm confused how to fix the tests. I see that pyre_test.py and the imports in __init__.py in tests folder are failing. I was under the assumption that the tests would fail since the top-level hack i did was only done locally (running pyre as python -m pyre-check.client.pyre ). I'm not sure how to replicate the behavior for the tests.

[gbleaney]

@m0mosenpai This is the command that the first test is running:
https://github.com/facebook/pyre-check/runs/3289612419?check_suite_focus=true#step:5:1

If you look into the script that runs that test, you can see that it just cds into the root of the repo, and runs the tests in the client folder:

pyre-check/scripts/run-python-tests.sh

Lines 10 to 13 in e40e8c2

	cd "${SCRIPTS_DIRECTORY}/.."
	echo ' Enumerating test files:'
	files=$(find client -name '*_test.py' ! -name 'watchman_test.py')

You should be able to just tweak that test to cd up one directory higher, and run the tests in pyre-check/client rather than just client

This is the command that the second test is running:
https://github.com/facebook/pyre-check/runs/3289612418?check_suite_focus=true#step:8:4

You can see that is just runs a second script:

pyre-check/documentation/deliberately_vulnerable_flask_app/run_integration_tests.sh

Lines 7 to 9 in e40e8c2

	python3 ../../tools/pysa_integration_tests/run.py \
	--skip-model-verification \
	--run-from-source

That test invokes the Pyre CLI from inside the pyre-check folder:

pyre-check/tools/pysa_integration_tests/utils.py

Lines 156 to 161 in e40e8c2

	command = [
	"python",
	"-m" "client.pyre",
	"--noninteractive",
	"analyze",
	]

pyre-check/tools/pysa_integration_tests/utils.py

Line 177 in e40e8c2

command, text=True, cwd=current_directory

You'll just need to change that to invoke from one dir higher, just like you did locally

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@m0mosenpai has updated the pull request. You must reimport the pull request before landing.