Skip to content

Commit

Permalink
Fix moveBefore feature detection (#32087)
Browse files Browse the repository at this point in the history
`moveBefore` was moved to the `ParentNode` mixin as per
whatwg/dom#1307 (comment) _(and was
committed in
whatwg/dom@3f3e94c5beda922962dacaeb606087f57bd7f7be)_

As a result, its existence can no longer be checked on `Node.prototype`
but must be checked in `Element.prototype`

DiffTrain build for [313c8c5](313c8c5)
  • Loading branch information
sebmarkbage committed Jan 17, 2025
1 parent 7784671 commit 683d4f1
Show file tree
Hide file tree
Showing 23 changed files with 92 additions and 92 deletions.
2 changes: 1 addition & 1 deletion compiled-rn/VERSION_NATIVE_FB
Original file line number Diff line number Diff line change
@@ -1 +1 @@
19.1.0-native-fb-43d18bc2-20250115
19.1.0-native-fb-313c8c55-20250117
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<df47e386bf1fe5abe7501a1937cbb301>>
* @generated SignedSource<<e70a699a30ca74f9d7860aefcd2b8954>>
*/

"use strict";
Expand Down Expand Up @@ -428,5 +428,5 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
exports.version = "19.1.0-native-fb-313c8c55-20250117";
})();
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<cdea6e896a523397ca5640b0abd0d114>>
* @generated SignedSource<<97e18a23e1ca60fdfd2c2b7572bba4b6>>
*/

"use strict";
Expand Down Expand Up @@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
exports.version = "19.1.0-native-fb-313c8c55-20250117";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<cdea6e896a523397ca5640b0abd0d114>>
* @generated SignedSource<<97e18a23e1ca60fdfd2c2b7572bba4b6>>
*/

"use strict";
Expand Down Expand Up @@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
exports.version = "19.1.0-native-fb-313c8c55-20250117";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<95576c45965431f7898adb25c6f79666>>
* @generated SignedSource<<9b5475e6242a629b6837dd80630a5fab>>
*/

/*
Expand Down Expand Up @@ -25545,7 +25545,7 @@ __DEV__ &&
: scheduleTimeout,
supportsMoveBefore =
"undefined" !== typeof window &&
"function" === typeof window.Node.prototype.moveBefore,
"function" === typeof window.Element.prototype.moveBefore,
NotLoaded = 0,
Loaded = 1,
Errored = 2,
Expand Down Expand Up @@ -25957,11 +25957,11 @@ __DEV__ &&
};
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.1.0-native-fb-43d18bc2-20250115" !== isomorphicReactPackageVersion)
if ("19.1.0-native-fb-313c8c55-20250117" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.1.0-native-fb-43d18bc2-20250115\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.1.0-native-fb-313c8c55-20250117\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -25998,10 +25998,10 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.1.0-native-fb-43d18bc2-20250115",
version: "19.1.0-native-fb-313c8c55-20250117",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115"
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -26147,5 +26147,5 @@ __DEV__ &&
listenToAllSupportedEvents(container);
return new ReactDOMHydrationRoot(initialChildren);
};
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
exports.version = "19.1.0-native-fb-313c8c55-20250117";
})();
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<4177fd9db345986e60e9ca1ca25f76e5>>
* @generated SignedSource<<9053a0d21feab58b0b8bfced7cee8265>>
*/

/*
Expand Down Expand Up @@ -14253,7 +14253,7 @@ function handleErrorInNextTick(error) {
}
var supportsMoveBefore =
"undefined" !== typeof window &&
"function" === typeof window.Node.prototype.moveBefore;
"function" === typeof window.Element.prototype.moveBefore;
function clearSuspenseBoundary(parentInstance, suspenseInstance) {
var node = suspenseInstance,
depth = 0;
Expand Down Expand Up @@ -15968,14 +15968,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_1785 = React.version;
if (
"19.1.0-native-fb-43d18bc2-20250115" !==
"19.1.0-native-fb-313c8c55-20250117" !==
isomorphicReactPackageVersion$jscomp$inline_1785
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1785,
"19.1.0-native-fb-43d18bc2-20250115"
"19.1.0-native-fb-313c8c55-20250117"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
Expand All @@ -15997,10 +15997,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_2241 = {
bundleType: 0,
version: "19.1.0-native-fb-43d18bc2-20250115",
version: "19.1.0-native-fb-313c8c55-20250117",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115"
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2242 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16106,4 +16106,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
listenToAllSupportedEvents(container);
return new ReactDOMHydrationRoot(initialChildren);
};
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
exports.version = "19.1.0-native-fb-313c8c55-20250117";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<bd521e4a43b2ab4756c72d452819a616>>
* @generated SignedSource<<9fccb2530410d5d87fdbd5f7036ef542>>
*/

/*
Expand Down Expand Up @@ -14894,7 +14894,7 @@ function handleErrorInNextTick(error) {
}
var supportsMoveBefore =
"undefined" !== typeof window &&
"function" === typeof window.Node.prototype.moveBefore;
"function" === typeof window.Element.prototype.moveBefore;
function clearSuspenseBoundary(parentInstance, suspenseInstance) {
var node = suspenseInstance,
depth = 0;
Expand Down Expand Up @@ -16617,14 +16617,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_1880 = React.version;
if (
"19.1.0-native-fb-43d18bc2-20250115" !==
"19.1.0-native-fb-313c8c55-20250117" !==
isomorphicReactPackageVersion$jscomp$inline_1880
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1880,
"19.1.0-native-fb-43d18bc2-20250115"
"19.1.0-native-fb-313c8c55-20250117"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
Expand All @@ -16646,10 +16646,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_1887 = {
bundleType: 0,
version: "19.1.0-native-fb-43d18bc2-20250115",
version: "19.1.0-native-fb-313c8c55-20250117",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115",
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117",
getLaneLabelMap: function () {
for (
var map = new Map(), lane = 1, index$292 = 0;
Expand Down Expand Up @@ -16770,4 +16770,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
listenToAllSupportedEvents(container);
return new ReactDOMHydrationRoot(initialChildren);
};
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
exports.version = "19.1.0-native-fb-313c8c55-20250117";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<6f219e9ed966b270c6abe28d9170a3ee>>
* @generated SignedSource<<03fc7add2e1d69fa14c6726377d06d2f>>
*/

/*
Expand Down Expand Up @@ -25606,7 +25606,7 @@ __DEV__ &&
: scheduleTimeout,
supportsMoveBefore =
"undefined" !== typeof window &&
"function" === typeof window.Node.prototype.moveBefore,
"function" === typeof window.Element.prototype.moveBefore,
NotLoaded = 0,
Loaded = 1,
Errored = 2,
Expand Down Expand Up @@ -26018,11 +26018,11 @@ __DEV__ &&
};
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.1.0-native-fb-43d18bc2-20250115" !== isomorphicReactPackageVersion)
if ("19.1.0-native-fb-313c8c55-20250117" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.1.0-native-fb-43d18bc2-20250115\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.1.0-native-fb-313c8c55-20250117\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -26059,10 +26059,10 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.1.0-native-fb-43d18bc2-20250115",
version: "19.1.0-native-fb-313c8c55-20250117",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115"
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -26524,7 +26524,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
exports.version = "19.1.0-native-fb-313c8c55-20250117";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<05f2a3ba7f0b7d0397114aebba97ae69>>
* @generated SignedSource<<6e44a9c4eeec2df75e1c5e16e235be2d>>
*/

/*
Expand Down Expand Up @@ -14253,7 +14253,7 @@ function handleErrorInNextTick(error) {
}
var supportsMoveBefore =
"undefined" !== typeof window &&
"function" === typeof window.Node.prototype.moveBefore;
"function" === typeof window.Element.prototype.moveBefore;
function clearSuspenseBoundary(parentInstance, suspenseInstance) {
var node = suspenseInstance,
depth = 0;
Expand Down Expand Up @@ -15979,14 +15979,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_1786 = React.version;
if (
"19.1.0-native-fb-43d18bc2-20250115" !==
"19.1.0-native-fb-313c8c55-20250117" !==
isomorphicReactPackageVersion$jscomp$inline_1786
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1786,
"19.1.0-native-fb-43d18bc2-20250115"
"19.1.0-native-fb-313c8c55-20250117"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
Expand All @@ -16008,10 +16008,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_2244 = {
bundleType: 0,
version: "19.1.0-native-fb-43d18bc2-20250115",
version: "19.1.0-native-fb-313c8c55-20250117",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115"
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2245 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16271,4 +16271,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
exports.version = "19.1.0-native-fb-313c8c55-20250117";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<459d2e101f76f4fd316aa429d387ad28>>
* @generated SignedSource<<ed6be6602fbeff1613925324886e3267>>
*/

/*
Expand Down Expand Up @@ -14898,7 +14898,7 @@ function handleErrorInNextTick(error) {
}
var supportsMoveBefore =
"undefined" !== typeof window &&
"function" === typeof window.Node.prototype.moveBefore;
"function" === typeof window.Element.prototype.moveBefore;
function clearSuspenseBoundary(parentInstance, suspenseInstance) {
var node = suspenseInstance,
depth = 0;
Expand Down Expand Up @@ -16632,14 +16632,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_1881 = React.version;
if (
"19.1.0-native-fb-43d18bc2-20250115" !==
"19.1.0-native-fb-313c8c55-20250117" !==
isomorphicReactPackageVersion$jscomp$inline_1881
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1881,
"19.1.0-native-fb-43d18bc2-20250115"
"19.1.0-native-fb-313c8c55-20250117"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
Expand All @@ -16661,10 +16661,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_1888 = {
bundleType: 0,
version: "19.1.0-native-fb-43d18bc2-20250115",
version: "19.1.0-native-fb-313c8c55-20250117",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-native-fb-43d18bc2-20250115",
reconcilerVersion: "19.1.0-native-fb-313c8c55-20250117",
getLaneLabelMap: function () {
for (
var map = new Map(), lane = 1, index$292 = 0;
Expand Down Expand Up @@ -16939,7 +16939,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.1.0-native-fb-43d18bc2-20250115";
exports.version = "19.1.0-native-fb-313c8c55-20250117";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
Loading

0 comments on commit 683d4f1

Please sign in to comment.