[compiler] ReactiveIR: refactor Branch/Fallthrough #32027
+92
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuing the exploration of the sea-of-nodes ReactiveIR. Three main changes: * ReactiveGraph has both entry and exit. Entry is mostly for completeness since it would be the first entry in the nodes map. * Moves the 'terminal' data from JoinNode to BranchNode. Each branch has both an entry and exit, but these are intended for use with reconstruction back to ReactiveFunction and for interpreting the IR or forward data flow analysis. * Renames JoinNode => FallthroughNode, removing the terminal. Combined with the previous changes — ensuring that every block ends in a terminal that has controls transitively through to its entry node — it's now always possible to reach all nodes from the exit and to walk forward for forward data flow analysis or abstract/actual interpretation of the instructions. [ghstack-poisoned]
This was referenced Jan 8, 2025
facebook-github-bot
added
CLA Signed
React Core Team
josephsavona
added a commit
that referenced
this pull request
Jan 8, 2025
Continuing the exploration of the sea-of-nodes ReactiveIR. Three main changes: * ReactiveGraph has both entry and exit. Entry is mostly for completeness since it would be the first entry in the nodes map. * Moves the 'terminal' data from JoinNode to BranchNode. Each branch has both an entry and exit, but these are intended for use with reconstruction back to ReactiveFunction and for interpreting the IR or forward data flow analysis. * Renames JoinNode => FallthroughNode, removing the terminal. Combined with the previous changes — ensuring that every block ends in a terminal that has controls transitively through to its entry node — it's now always possible to reach all nodes from the exit and to walk forward for forward data flow analysis or abstract/actual interpretation of the instructions. ghstack-source-id: 23f3e74b57347e321a77381e1f0d14b63569e1af Pull Request resolved: #32027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Continuing the exploration of the sea-of-nodes ReactiveIR.
Three main changes:
Combined with the previous changes — ensuring that every block ends in a terminal that has controls transitively through to its entry node — it's now always possible to reach all nodes from the exit and to walk forward for forward data flow analysis or abstract/actual interpretation of the instructions.